chore: support officially maintained pg versions (13 to 17)#4
chore: support officially maintained pg versions (13 to 17)#4EQuincerot merged 3 commits intomainfrom
Conversation
EQuincerot
force-pushed
the
support_other_pg_versions
branch
from
dfafe60 to
d55a22a
Compare
EQuincerot
force-pushed
the
support_other_pg_versions
branch
from
445059d to
63a2ffb
Compare
EQuincerot
changed the title
|
|
||
| #[pg_guard] | ||
| pub extern "C" fn _PG_init() { | ||
| pub extern "C-unwind" fn _PG_init() { |
There was a problem hiding this comment.
Required when upgrading pgrx: see release notes
| } | ||
| } | ||
| #[cfg(not(any(feature = "pg13", feature = "pg14")))] | ||
| CmdType::CMD_MERGE => { |
There was a problem hiding this comment.
| #[cfg(not(any(feature = "pg13", feature = "pg14")))] | ||
| let table_oid = scanned_table(seq_scan.scan.scanrelid, rtables).unwrap(); | ||
| #[cfg(any(feature = "pg13", feature = "pg14"))] | ||
| let table_oid = scanned_table(seq_scan.scanrelid, rtables).unwrap(); |
There was a problem hiding this comment.
It seems the scanrelid was accessible in a different way before pg15.
There was a problem hiding this comment.
that's, cool. I didn't know that you could write code for specific versions of pg with that macro.
|
|
||
| [features] | ||
| default = ["pg15"] | ||
| default = ["pg17"] |
There was a problem hiding this comment.
Use the latest version as default, as this is the one which is closest to the future version.
| - name: 🧪 Test - PG ${{ matrix.pg }} | ||
| run: pgrx-build-test | ||
| - name: 📎 Clippy - PG ${{ matrix.pg }} | ||
| if: ${{ matrix.pg == '17' }} |
There was a problem hiding this comment.
Only run for the latest version, we should not have big differences on other versions, and it should be enough.
imediava-doctolib
left a comment
imediava-doctolib
left a comment
There was a problem hiding this comment.
LGTM !
Thanks for the work to make the extension work on different pg versions.
2 participants
Uh oh!
There was an error while loading. Please reload this page.